-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple processing element for the switch demo #719
Open
hiddemoll
wants to merge
12
commits into
staging
Choose a base branch
from
hidde/switch-demo-pe
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+840
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d0d5c8b
to
989b79a
Compare
58ac6a6
to
33588d7
Compare
3a58416
to
a97b15d
Compare
1e26ce4
to
31a33f9
Compare
martijnbastiaan
approved these changes
Feb 19, 2025
53efd23
to
66bf8c2
Compare
The incremented size of `readCycles` better matches the intended number of tri-cycles the user writes in Rust, since this makes no sense to be zero-indexed.
Having a lower max debug level for a debug build than a release build makes no sense. The maximum level for a debug build is now 'trace' (the highest) and for a release build it is 'info'.
The 'features' of the log module set in the respective Cargo.toml are global. Adding other features in two Cargo.toml files in the same module gives a duplicate features error. Using the log module is slower than the previous method of a global constant boolean `DEBUG_MODE` with if-statements around `uwrite` calls. Therefore, I had to increase the values for when to start reading/writing in the switch demo PE test.
By also returning the DNA, instead of only having it wishbone accessible, we can also use the device DNA in hardware.
66bf8c2
to
7165f89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.